Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit individual list items. #54

Merged
merged 8 commits into from
Oct 13, 2024

Conversation

Hudamabkhoot
Copy link
Collaborator

Description

Users can now edit their item details directly through the "Edit Item" form. This feature allows them to modify the item name, update the next purchase date, and adjust the quantity.

Related Issue

closes #49

Acceptance Criteria

  • Users should be able to edit their list items details.

Type of Changes

Feature

Updates

Before

Screen Shot 2024-10-12 at 6 11 02 PM

After

Screen Shot 2024-10-12 at 6 11 02 PM
Screen Shot 2024-10-12 at 6 28 59 PM
Screen Shot 2024-10-12 at 6 29 09 PM

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-edit-listItem.
  • Open the homepage by running npm start.
  • Navigate to the list page.
  • The edit item functionality should now be in a modal triggered by the pencil icon next to the delete button.
  • You can now modify the item name, update the next purchase date, and adjust the quantity.

al chnages and fixing the issue of listName being null
@Hudamabkhoot Hudamabkhoot changed the title Hm edit list item Edit individual list items. Oct 12, 2024
Copy link

github-actions bot commented Oct 12, 2024

Visit the preview URL for this PR (updated for commit b8d5d5c):

https://tcl-79-smart-shopping-list--pr54-hm-edit-listitem-cezd4csr.web.app

(expires Sun, 20 Oct 2024 14:58:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this additional feature!
Small note I think the pencil and trash can should be two different colours but not necessarily the pinks and greens we use throughout the app(cause there is a lot of colour going on) Maybe just black/dark grey/dark slate on Light mode and a a light grey/slate on Dark mode? I don't know🤷🏾‍♀️

src/components/ManageListForms/EditItemForm.jsx Outdated Show resolved Hide resolved
@Hudamabkhoot
Copy link
Collaborator Author

Hudamabkhoot commented Oct 13, 2024

I did the following in my recent commits:

  • Modified the on hover opacity of list items buttons and matched the design of home and list buttons.
  • Matched the dialogs buttons.
  • Added a loading state so the add list items div wont show as the data is loading.
  • Added the inactive share button to match the inactive delete button.
  • Also solved conflicts with dev branch.

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and really nice feature! Well done

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay!
Just the loading state now stays if there are
no items on a new list and you can't see the add item button that was visible previously.

Screenshot 2024-10-13 at 13 20 53 Screenshot 2024-10-13 at 13 22 12

@Hudamabkhoot Hudamabkhoot merged commit 3220f21 into feat/setup-tailwind-shadcn Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants