Fi navlink css #40
Fi navlink css #40
Conversation
| @@ -9,10 +9,11 @@ | |||
| "prettier": "^1.19.1", | |||
| "react": "^16.13.1", | |||
| "react-dom": "^16.13.1", | |||
| "react-firestore": "^1.0.1", | |||
| "react-icons": "^3.11.0", | |||
There was a problem hiding this comment.
I see you added a new package! I'm excited to hear you talk about how you found it and why you decided to use it. I've never heard of it before!
There was a problem hiding this comment.
This looks like a cool package. Nice find!
| } | ||
|
|
||
| .navlink-active { | ||
| font-weight: 900; |
There was a problem hiding this comment.
Do we have a font weight of 900? If we're using our font-family: 'Source Sans Pro', sans-serif; as our default font in our App.css, I think we only have 300 and 400 weights downloaded for that font. Please correct me if I'm wrong because I don't know a ton about font weights.
There was a problem hiding this comment.
@fab33150, great work! I love how focused this branch and the solution is too the larger task of finishing up three different, but related issues! Awesome.
| @@ -9,10 +9,11 @@ | |||
| "prettier": "^1.19.1", | |||
| "react": "^16.13.1", | |||
| "react-dom": "^16.13.1", | |||
| "react-firestore": "^1.0.1", | |||
| "react-icons": "^3.11.0", | |||
There was a problem hiding this comment.
This looks like a cool package. Nice find!
For an example of how to fill this template out, see this Pull Request.
Description
Utilized the react-icons npm package to add icons to the List and AddItem navigation links. Also, added additional styling to the links.
Related Issue
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria