Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing pkg manager version #312

Merged
merged 5 commits into from
Dec 5, 2023
Merged

feat: allow passing pkg manager version #312

merged 5 commits into from
Dec 5, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Dec 4, 2023

Proof it works:
CleanShot 2023-12-04 at 17 35 59

graphprotocol/graph-tooling#1528

closes #311

Copy link

changeset-bot bot commented Dec 4, 2023

⚠️ No Changeset found

Latest commit: 2eae97a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saihaj saihaj requested a review from dotansimha December 4, 2023 22:21
@dotansimha
Copy link
Member

@saihaj can we test it on one of the repos that already use pnpm v8? just to make sure this new input and pnpm version picking is not breaking anything

@saihaj
Copy link
Member Author

saihaj commented Dec 5, 2023

does work @dotansimha

CleanShot 2023-12-05 at 15 52 10

dotansimha/graphql-yoga#3130

@saihaj saihaj merged commit 87c41cc into main Dec 5, 2023
@saihaj saihaj deleted the saihaj/311 branch December 5, 2023 20:53
@EmrysMyrddin
Copy link
Member

This has broken the release action of yoga, I don't know why it worked in your test, but it seems the type attribute is detected as required in this action: https://github.com/n1ru4l/envelop/actions/runs/7168575591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for passing version number for package manger
3 participants