Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added injury effects table #184

Conversation

Doc-Sun
Copy link

@Doc-Sun Doc-Sun commented Nov 25, 2024

Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
Added Missing tables from the beta rules that were missing that could be used for rolling or choosing.

Related Issue
Half closes Closes #183

How Has This Been Tested?
Tested and built in foundry, exported .json and added to repo

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: [12.331].

Additional context
Add any other context or information here that would be useful for reviewers.

Copy link
Collaborator

@MangoFVTT MangoFVTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shardblade injuries are a Stormlight exclusive and should definitely be moved to a module (probably to the playtest materials for now). The other one can stay 👍 We'll need to think of styling for these as well I suspect, in order to be able to apply the effect directly from the chat cards

@Doc-Sun Doc-Sun changed the title chore: added injury effects and shardblade injury tables chore: added injury effects injury table Nov 25, 2024
@Doc-Sun
Copy link
Author

Doc-Sun commented Nov 25, 2024

Shardblade injuries are a Stormlight exclusive and should definitely be moved to a module (probably to the playtest materials for now). The other one can stay 👍 We'll need to think of styling for these as well I suspect, in order to be able to apply the effect directly from the chat cards

Thanks. Removed the shardblades chart from this PR and renamed the PR

@MangoFVTT MangoFVTT self-requested a review November 25, 2024 18:17
@Doc-Sun Doc-Sun changed the title chore: added injury effects injury table chore: added injury effects table Nov 25, 2024
src/packs/tables/injury-effects.json Outdated Show resolved Hide resolved
src/packs/tables/injury-effects.json Outdated Show resolved Hide resolved
src/packs/tables/injury-effects.json Outdated Show resolved Hide resolved
src/packs/tables/injury-effects.json Outdated Show resolved Hide resolved
@Doc-Sun Doc-Sun requested a review from MangoFVTT November 25, 2024 18:29
@Doc-Sun Doc-Sun marked this pull request as ready for review November 25, 2024 18:29
@Doc-Sun Doc-Sun requested a review from MangoFVTT November 25, 2024 19:11
@zithith
Copy link
Collaborator

zithith commented Nov 26, 2024

Would be kinda good to have the conditions somewhere as Items in the system so that these could have documentIds, but that's a thought for another day

@Doc-Sun
Copy link
Author

Doc-Sun commented Nov 26, 2024

Would be kinda good to have the conditions somewhere as Items in the system so that these could have documentIds, but that's a thought for another day

That would be nice (id really like them to be like the pf2e conditions that even show up in the top right of the screen with hover over text when placed on a actor token and that token is selected) but thats a little beyond me for today. This I can do

MangoFVTT
MangoFVTT previously approved these changes Nov 26, 2024
@zithith zithith merged commit c54358d into the-metalworks:release-0.2.2 Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants