feat: support user to cumtom prompt for current conversation by dalton-ly · Pull Request #1214 · the-open-agent/openagent

dalton-ly · 2025-05-11T13:18:45Z

support #979

hsluoyz · 2025-05-26T06:47:18Z

@dalton-ly

Should not contain the previous merged PR as below, needs to rebase
Provide a demo video

dalton-ly · 2025-05-26T14:42:58Z

rebased onto latest master
Demo in attachment

prompt_set_demo.zip
@hsluoyz

dalton-ly · 2025-06-08T08:56:18Z

0608 fix bug and rebased

hsluoyz · 2025-06-12T14:09:19Z

 	"strings"

 	"github.com/beego/beego"
+	"github.com/beego/beego/logs"


Don't use Beego logs

hsluoyz · 2025-06-12T14:10:04Z

+// @Param prompt body string true "The custom prompt"
+// @Success 200 {object} controllers.Response "Success"
+// @router /set-chat-prompt [post]
+func (c *ApiController) SetChatPrompt() {


Don't need to add new API, see how this UI widget works:

hsluoyz · 2025-06-12T14:11:08Z

          )}
        </Card>
-
+        <Modal


The new modal UI should be in a new JS file

hsluoyz · 2025-06-12T14:11:23Z


  return (
-    <div style={{position: "absolute", bottom: 0, left: 0, right: 0, padding: "16px 24px", zIndex: 1}}>
+    <div style={{


Don't change original code format

hsluoyz · 2025-06-12T14:11:46Z

+
+	promptToUse := store.Prompt
+	if chat.CustomPrompt != "" {
+		promptToUse = chat.CustomPrompt


Don't replace store.Prompt, append is better

hsluoyz · 2025-06-12T14:11:57Z

+// @Param id query string true "The id of chat"
+// @Success 200 {object} controllers.Response "Success"
+// @router /get-chat-prompt [get]
+func (c *ApiController) GetChatPrompt() {


Don't need to add new API

hsluoyz · 2025-06-12T14:12:02Z

  }).then(res => res.json());
 }
+
+export function getChatPrompt(id) {


Don't need to add new API

hsluoyz · 2025-06-12T14:12:05Z

+  }).then(res => res.json());
+}
+
+export function setChatPrompt(id, prompt) {


Don't need to add new API

dalton-ly · 2025-06-22T15:56:07Z

fixed @hsluoyz
https://github.com/user-attachments/assets/1b0235bc-f674-4042-8688-cd82b07910c0

Copilot

Pull Request Overview

This PR adds support for setting a custom prompt on a per-conversation basis in both the front-end chat UI and the back-end message handling.

Introduces a PromptModal component for editing prompts.
Extends ChatInput, ChatBox, and ChatPage to manage prompt state, persist it in localStorage, and pass it through the UI.
Updates the Go backend (message.go and message_answer.go) to store and append the custom prompt when querying the model.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
web/src/chat/PromptModal.js	New modal allowing users to view/edit prompts
web/src/chat/ChatInput.js	Adds a settings button for opening the prompt modal
web/src/ChatPage.js	Manages `chatPrompt` state, load/save from localStorage
web/src/ChatBox.js	Integrates `PromptModal`, passes prompt through props
object/message.go	Adds `CustomPrompt` field to `Message` struct
controllers/message_answer.go	Appends `CustomPrompt` to the model query string

Comments suppressed due to low confidence (1)

web/src/ChatPage.js:169

The new updateChatPrompt method (and related loadChatPrompt) aren’t covered by existing tests. Consider adding unit or integration tests to verify prompt persistence and retrieval.

  updateChatPrompt = (prompt) => {

Copilot · 2025-07-08T00:41:08Z

 			AgentMessages: messages,
 		}
-		modelResult, err = model.QueryTextWithTools(modelProviderObj, question, writer, history, store.Prompt, knowledge, agentInfo)
+		modelResult, err = model.QueryTextWithTools(modelProviderObj, question, writer, history, store.Prompt+customPrompt, knowledge, agentInfo)


Concatenating store.Prompt and customPrompt without a separator can merge sentences. Consider inserting a newline or space between them, e.g., store.Prompt + "\n" + customPrompt.

Copilot · 2025-07-08T00:41:08Z

+        padding: "20px 24px",
+      }}
+    >
+      <textarea


The <textarea> lacks an explicit aria-label or associated <label>. Adding one will improve screen reader support.

Copilot · 2025-07-08T00:41:08Z

+        value={editingPrompt}
+        onChange={(e) => setEditingPrompt(e.target.value)}
+        placeholder={i18next.t("chat:Set a custom prompt for this conversation")}
+        style={{


[nitpick] This component has a large inline style block. Extracting styles into a CSS module or styled-component could improve readability and reuse.

hsluoyz · 2025-07-08T00:41:42Z

@dark-Qy @IsAurora6 plz review

dark-Qy · 2025-07-08T01:26:09Z

 	ErrorText         string        `xorm:"mediumtext" json:"errorText"`
 	FileName          string        `xorm:"varchar(100)" json:"fileName"`
 	Comment           string        `xorm:"mediumtext" json:"comment"`
+	CustomPrompt      string        `xorm:"mediumtext" json:"customPrompt"`


Why use message object to store custom prompt instead of chat object?

dark-Qy · 2025-07-08T01:28:08Z


+    this.setState({chatPrompt: prompt});
+
+    const chatId = this.state.chat.owner + "/" + this.state.chat.name;


Since message object is used, why does the frontend use chatPrompt_${chatId} as key to store prompt in localStorage - this is inconsistent

dark-Qy · 2025-07-08T01:29:07Z

+    this.setState({chatPrompt: prompt});
+
+    const chatId = this.state.chat.owner + "/" + this.state.chat.name;
+    localStorage.setItem(`chatPrompt_${chatId}`, prompt);


Why use localStorage in frontend? Data will be lost when switching devices

dalton-ly force-pushed the add_prompt branch from 063ad86 to 54d87de Compare May 11, 2025 13:27

dalton-ly force-pushed the add_prompt branch 2 times, most recently from 0a933b9 to dbe6584 Compare May 26, 2025 14:21

dalton-ly force-pushed the add_prompt branch 2 times, most recently from 9fc23a0 to df7a530 Compare June 8, 2025 08:48

hsluoyz requested changes Jun 12, 2025

View reviewed changes

hsluoyz force-pushed the master branch from 4158a3d to 49c4967 Compare June 14, 2025 07:01

dalton-ly force-pushed the add_prompt branch 2 times, most recently from 7f76b33 to 7fda78d Compare June 22, 2025 15:18

feat: support custom prompt

39a58cd

dalton-ly force-pushed the add_prompt branch from 7fda78d to 39a58cd Compare June 22, 2025 15:19

dalton-ly requested a review from hsluoyz July 4, 2025 02:45

hsluoyz requested a review from Copilot July 8, 2025 00:39

Copilot AI reviewed Jul 8, 2025

View reviewed changes

dark-Qy reviewed Jul 8, 2025

View reviewed changes

hsluoyz force-pushed the master branch from 03fea78 to 33b17ec Compare July 20, 2025 17:25

hsluoyz force-pushed the master branch 2 times, most recently from b0af169 to 1beb94c Compare August 2, 2025 02:01

hsluoyz force-pushed the master branch from c0e6a53 to e54c6dc Compare September 24, 2025 15:49

hsluoyz force-pushed the master branch 3 times, most recently from 4f4385d to c484e8b Compare October 22, 2025 17:34

hsluoyz force-pushed the master branch 2 times, most recently from 16e8006 to 57f99cb Compare November 4, 2025 17:18

hsluoyz force-pushed the master branch 8 times, most recently from 8be752c to 1ba19a5 Compare November 8, 2025 17:08

hsluoyz force-pushed the master branch from 1a86339 to 1641ce0 Compare November 16, 2025 09:55

hsluoyz force-pushed the master branch from 3a2961e to a585a44 Compare December 10, 2025 07:49

hsluoyz force-pushed the master branch 2 times, most recently from 0c1315e to 41f7b24 Compare February 14, 2026 16:41

hsluoyz force-pushed the master branch 3 times, most recently from 1c86c55 to bfd6eca Compare May 3, 2026 06:53

nomeguy force-pushed the master branch from faa24f3 to a5988d2 Compare May 9, 2026 15:02

hsluoyz force-pushed the master branch 2 times, most recently from 0d5f732 to 5b80c35 Compare May 23, 2026 09:17

hsluoyz force-pushed the master branch 2 times, most recently from 008ecd9 to ed8fc87 Compare June 3, 2026 08:28

hsluoyz force-pushed the master branch 2 times, most recently from 937a559 to 2f734e0 Compare June 12, 2026 15:02

hsluoyz force-pushed the master branch 2 times, most recently from 36714c2 to 6369263 Compare June 17, 2026 17:25

hsluoyz force-pushed the master branch 2 times, most recently from b8bb53e to dc5af21 Compare June 26, 2026 16:19

hsluoyz force-pushed the master branch from 3181311 to a8caaa4 Compare July 6, 2026 15:13

                         )}
                       </Card>
+                      <Modal


		this.setState({chatPrompt: prompt});

		const chatId = this.state.chat.owner + "/" + this.state.chat.name;

Uh oh!

Conversation

dalton-ly commented May 11, 2025

Uh oh!

hsluoyz commented May 26, 2025

Uh oh!

dalton-ly commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dalton-ly commented Jun 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dalton-ly commented Jun 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

hsluoyz commented Jul 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dalton-ly commented May 26, 2025 •

edited

Loading