Prevent Paperless crash when consume folder is unavailable #629
Conversation
|
2 approving reviews - can some one from the core team please have a look, I mean the checks are fine? Is anybody still out there or is the project dead, just like the parrot? |
|
Shouldn't it crash here, too? Or basically anywhere it tries to access any file on the network drive later on or do the other functions all catch the occurring exceptions? |
|
I haven't experienced a crash at that location. Furthermore, it never gets there, since my addition prevents that. |
Bring fork up to date
|
@MasterofJOKers & @pitkley any chance to get this merged this weekend? |
|
@BastianPoe , any chance you support this merge? |
|
Looks good to me - but I am no admin and hence cannot approve the PR. |
|
Hallo Bastian
Jetzt wo du es sagst, den habe ich mal verfolgt und gehofft auf einen merge.
Okay ich schreibe jetzt Daniel Quinn.
Vielen Dank für den Hinweis
en Gruess
Reto
…________________________________
Von: Wolf-Bastian Pöttner <[email protected]>
Gesendet: Freitag, 24. Juli 2020 18:28
An: the-paperless-project/paperless <[email protected]>
Cc: Reto <[email protected]>; Comment <[email protected]>
Betreff: Re: [the-paperless-project/paperless] Prevent Paperless crash when consume folder is unavailable (#629)
Hi!
Are you aware of #652<#652>? It does fix this issue and adds a bunch of tests. Unfortunately nobody has been reviewing it for more than a month now.
Bastian
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#629 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACRKFBWV6T4SQT7D6M45NADR5GZBXANCNFSM4MJ7ZWRQ>.
|
|
@danielquinn in #470 you say you try to get PR merged, but as of now we get double-PRs because you didn't merge. Can you please:
Thank you and sorry to bother. Cheers |
When the consume folder for paperless is on a network drive, and that location is (temporary) unavailable, then the consumer in docker crashes. The only way to resume is by manually restarting the container.
This small addition catches the error and prevents the consumer from crashing. The cosumer resumes it's duties after the location is available again.