Add limit-capture-size option #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using --limit-capture-size, tcpdump can now exit after capturing a specified amount of data. If used with -w, tcpdump will exit after writing the specified limit to disk. Without -w, tcpdump will exit reaching the limit based on packets*h->len. Works with -C/-W/-G options. The method for specifying file size for -C and --limit-capture-size was updated to allow users to enter num[k,m,g,ki,mi,gi]. Leaving off units will result in the current behavior of an argument being multiplied by a default of 1000000. This commit updates and improves upon work done by @stevekay for feature request 97 and pull request 464.
|
Upon further review, there are a few minor cleanups I'd like to do: I'll wait for other comments and include those before committing. |
|
will this go in? @DEADBEEFh can you update the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using --limit-capture-size, tcpdump can now exit after capturing
a specified amount of data. If used with -w, tcpdump will exit
after writing the specified limit to disk. Without -w, tcpdump
will exit reaching the limit based on packets*h->len.
Works with -C/-W/-G options.
The method for specifying file size for -C and
--limit-capture-size was updated to allow users to enter
num[k,m,g,ki,mi,gi]. Leaving off units will result in the current
behavior of an argument being multiplied by a default of 1000000.
This commit updates and improves upon work done by @stevekay for
feature request 97 and pull request 464.