Skip to content

test: verify Codecov PR flow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the0807 wants to merge 2 commits into from
Closed

test: verify Codecov PR flow #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34bbe30
docs: clarify why getRemoteNames uses a 30s TTL
the0807 May 17, 2026
62bea2c
refactor: extract remote-names cache TTL into a named constant
the0807 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/git/git-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export class GitError extends Error {
}
}

const REMOTE_NAMES_CACHE_TTL_MS = 30_000;

export class GitService {
private activityLog: Array<{ command: string; timestamp: string; success: boolean; duration: number }> = [];
private cachedRemoteNames: string[] | null = null;
Expand Down Expand Up @@ -368,7 +370,8 @@ export class GitService {

private async getRemoteNames(): Promise<string[]> {
const now = Date.now();
if (this.cachedRemoteNames && now - this.remoteNamesCacheTime < 30000) {
// Remote names rarely change at runtime; addRemote/removeRemote invalidate explicitly.
if (this.cachedRemoteNames && now - this.remoteNamesCacheTime < REMOTE_NAMES_CACHE_TTL_MS) {
return this.cachedRemoteNames;
}
// Dedupe concurrent callers: if a request is already in flight, await it
Expand Down
Loading