Repository navigation
Conversation
Fixes theagentrouter#2926 Signed-off-by: Phung Quang Minh <minh8a1hb@gmail.com>
✅ Deploy Preview for theagentrouter canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Encode the existing user-facing error envelope with the approved internal JSON encoder. Quoted messages, backslashes, newlines and control characters now produce valid JSON. Preserve the string-valued status code, empty message fields, HTTP statuses and gRPC statuses.
Related Issues/PRs
Fixes #2926
Special notes for reviewers
Unit and processor regressions cover escaped text and response metadata. The selected Envoy multipart invalid-temperature case verifies strict JSON at the data-plane boundary.
Validation: make precommit test; selected serializer/response/processor unit tests; selected Envoy multipart-temperature data-plane test. These checks passed locally.
AI assistance was used for investigation, implementation, regression tests and this description. Human ownership and review remain with the contributor.