theatre/r3f: Allow physical lighting in snapshot viewport #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for theatrejs-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@AndrewPrifer should this go in? |
|
Hey @vezwork thanks for the reminder, completely forgot about this. There are some conflicts to resolve, gonna merge it later today. |
# Conflicts: # packages/r3f/src/components/SnapshotEditor.tsx
# Conflicts: # packages/r3f/src/components/SnapshotEditor.tsx # packages/r3f/src/components/editorStuff.ts
|
@AndrewPrifer is attempting to deploy a commit to the Theatrejs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
renderer.physicallyCorrectLights = truepmndrs/react-three-fiber#2127I'd encourage any new project to enable
renderer.physicallyCorrectLights=true, but it's difficult to change the default in three.js or R3F at this point. There is no downside to physical lighting (you can still reduce decay for non-physical light range if needed), we're just stuck with it off for backward-compatibility. In order to at least support the more modern and correct workflow, could we expose this as a viewport option?This contribution is funded by The New York Times.