Update manifest permissions to match medium url #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for catching this and submitting the pull request! The only problem is that this means the extension won't work on custom domain publications, like https://hackernoon.com/. I know it's not the best to ask permission for all sites, but I think the solution suggested in #15 is the best way to go. Feel free to tackle that if you want! |
thebaer
added a commit
that referenced
this pull request
Mar 31, 2018
Now does a case-insensitive check for "Medium" in meta tag. This addresses the issue brought up in #22.
Merged
|
Closing now. Best solution will be implementing #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This if statement
is no longer working, because they changed head meta tag to be
... content="Medium" ..(note the uppercaseM), so the content script won't fire at all.I've changed required permissions, its not good practice to ask permissions to all pages anyway.