Fixed stack memory corruption due to strcat() function #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The problem with memory stack corruption occurred in the 'fetch_saveimagepath()' function when starting the emulator.
Because the memory allocated on the stack `TCHAR path[MAX_DPATH]` in function `DISK_get_default_saveimagepath` does not have a end of line marker ('/0').
That's why further call of the strcat() function which first searches for a zero byte and then adds another string to it resulted in stack corruption in this place and application crash as a consequence.
- In other similar functions, the same scenario is possible.
Compilation error, I forgot to specify the variable name
- The problem with memory stack corruption occurred in the 'fetch_saveimagepath()' function when starting the emulator.
Because the memory allocated on the stack `TCHAR path[MAX_DPATH]` in function `DISK_get_default_saveimagepath` does not have a end of line marker ('/0').
That's why further call of the strcat() function which first searches for a zero byte and then adds another string to it resulted in stack corruption in this place and application crash as a consequence.
- In other similar functions, the same scenario is possible.
- My Intel processor 2011 does not support SSE3 extensions, in particular 'movbe' instruction. As a result, the emulator crashes with the error 'illegal instruction' Therefore, I would recommend leaving the original #ifdef HAVE_MOVBE
|
Thanks for the fixes. As you can see lots of the code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCHAR path[MAX_DPATH]in functionDISK_get_default_saveimagepathdoes not have a end of line marker ('/0'). That's why further call of the strcat() function which first searches for a zero byte and then adds another string to it resulted in stack corruption in this place and application crash as a consequence.In other similar functions, the same scenario is possible.
I'm sorry, seems to I don't really know GitHub yet.
Because I made second comit with the optional enabling of SSE3 instructions (like 'movbe'). But they merged into one pull-request.