Made QMMLOG macro to speed up logging that isn't used#41
Merged
Conversation
…is actually active in either the log file sink or game console sink. removed all uses of fmt::format in logging, switching to using stream insertion
…o (int severity, const char* fmt, ...) and now supports varargs, which it will ignore entirely if the desired log severity is not met
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At point of use, it checks whether the log severity is greater than both the log sink level and the game console sink level. Also removed all uses of fmt::format in logging.
Now all logging is in all builds (not locked behind _DEBUG) and server startup time is a few milliseconds faster than the old release version and dozens of seconds faster than the old debug version, with logging at INFO level.