Fix: Deprecated Dynamic Property Creation in PHP 8.3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of deprecated dynamic property creation in PHP 8.3, as reported in issue #9. The fix involves explicitly declaring the
$themes_folderproperty in theThemesServiceProviderclass to comply with PHP 8.3's stricter property handling.Changes
$themes_folderproperty declaration inThemesServiceProvider.bootmethod to use the newly declared property.Impact
This change ensures that
thedevdojo/themesis compatible with PHP 8.3 and prevents the "Deprecated: Creation of dynamic property" error from being triggered.Testing
The changes have been tested in a local environment running PHP 8.3 to ensure that the deprecation warning is resolved and that the functionality of the
ThemesServiceProviderremains unaffected.References
I look forward to any feedback or suggestions regarding this pull request. Thank you for considering this contribution!