fix(openclaw): avoid /dev/tty crash in --non-interactive and handle allowlist bootstrap#1310
Open
nillin wants to merge 1 commit intothedotmack:mainfrom
Open
fix(openclaw): avoid /dev/tty crash in --non-interactive and handle allowlist bootstrap#1310nillin wants to merge 1 commit intothedotmack:mainfrom
nillin wants to merge 1 commit intothedotmack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes two installer failure modes seen during
--upgradeon OpenClaw:/dev/ttyand failed with:main: line 85: /dev/tty: No such device or addressplugins.allowalready includesclaude-membut the plugin is not installed yet.OpenClaw validates config before
plugins installcan complete, so install fails with:plugins.allow: plugin not found: claude-memChanges
setup_tty()now short-circuits when--non-interactiveis set (never opens/dev/tty)./dev/ttyopen path (-r /dev/tty+ guardedexec).claude-memfromplugins.allowtemporarily.plugins.allowentry after successful install+enable if it existed previously.Why this is safe
entries.claude-mem.config) remains intact.Validation
bash -n openclaw/install.shpasses.