Skip to content

fix(chroma): close transport before nulling to prevent subprocess leak #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuelfedele wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chroma): close transport before nulling to prevent subprocess leak #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/services/sync/ChromaMcpManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,17 @@ export class ChromaMcpManager {
// Transport error: chroma-mcp subprocess likely died (e.g., killed by orphan reaper,
// HNSW index corruption). Mark connection dead and retry once after reconnect (#1131).
// Without this retry, callers see a one-shot error even though reconnect would succeed.
//
// CRITICAL: Close the transport before nulling to kill the subprocess (#1369).
// If we null this.transport first, connectInternal() sees transport === null,
// skips cleanup, and spawns a new subprocess, orphaning the old one.
this.connected = false;
const staleTransport = this.transport;
this.client = null;
this.transport = null;
if (staleTransport) {
try { await staleTransport.close(); } catch { /* subprocess may already be dead */ }
}

logger.warn('CHROMA_MCP', `Transport error during "${toolName}", reconnecting and retrying once`, {
error: transportError instanceof Error ? transportError.message : String(transportError)
Expand All @@ -267,7 +275,14 @@ export class ChromaMcpManager {
arguments: toolArguments
});
} catch (retryError) {
// Retry also failed. Close transport to prevent another orphan.
this.connected = false;
const retryTransport = this.transport;
this.client = null;
this.transport = null;
if (retryTransport) {
try { await retryTransport.close(); } catch { /* subprocess may already be dead */ }
}
throw new Error(`chroma-mcp transport error during "${toolName}" (retry failed): ${retryError instanceof Error ? retryError.message : String(retryError)}`);
}
}
Expand Down