Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for use with Textual 0.9.1 #21

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

castaway
Copy link

Description:

Codebase / User Interface now runs with Textual 0.9.1 release and Bluetooth Numbers 1.0.0
No functional changes to the interface

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@castaway
Copy link
Author

WIP / Draft because: The table view does not currently scroll up/down when using the mouse wheel. Does it on the older version of Textual? If so I think I probably need to swap the main ScrollView / Table for Container / DataTable, which is a subclass of ScrollView. (ScrollView itself is no longer exported as a main Textual widget)

@koenvervloesem
Copy link
Member

Hi, thanks for this effort! Have you taken a look at the code of humble-explorer? I used a DataTable there instead of a ScrollView. Scrolling works that way. I also had to create the BleakScanner object in the app's on_mount method to be able to run it on macOS (koenvervloesem/humble-explorer#27).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants