Add hint about related setting for REX concurrency #4239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
maximiliankolb
commented
Sep 11, 2025
| @@ -43,6 +43,9 @@ Is used if effective user is different from the ssh user. | |||
| Concurrency level:: | |||
| Defines the maximum number of jobs executed at once. | |||
| This can prevent overload of system resources in a case of executing the job on a large number of hosts. | |||
| + | |||
| If `foreman_proxy_ansible_batch_size` is set, {SmartProxies} run batches of concurrent remote execution jobs. | |||
There was a problem hiding this comment.
Does this only work for foreman_ansible, but not for foreman_remote_execution?
There was a problem hiding this comment.
Does foreman_remote_execution "borrow" the setting from foreman-tasks? theforeman/foreman_remote_execution@8016206 & https://github.com/theforeman/foreman-tasks/blob/master/app/lib/actions/proxy_action.rb#L207
Fixes #38247 (Missing docs on how to REX batching works)
maximiliankolb
force-pushed
the
proxy_batch_triggering
branch
from
a784efe to
7407c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Fixes #38247 (Missing docs on how to REX batching works)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Untested!
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):