Skip to content

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Sep 14, 2025

What changes are you introducing?

Removing guides/common/modules/snip_note-custom-templates-unsupported.adoc

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Snippet is very short and used only once.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

No tech review or testing required.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

Review checklists

Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):

  • The PR documents a recommended, user-friendly path.
  • The PR removes steps that have been made unnecessary or obsolete.
  • Any steps introduced or updated in the PR have been tested to confirm that they lead to the documented end result.

Style review (by a Technical Writer who did not author the PR):

  • The PR conforms with the team's style guidelines.
  • The PR introduces documentation that describes a user story rather than a product feature.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 14, 2025
@apinnick apinnick removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Sep 14, 2025
Copy link

github-actions bot commented Sep 14, 2025

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM. Tech-wise: it should probably only be visible for Satellite and orcharhino. It's currently also visible for Katello: https://docs.theforeman.org/nightly/Managing_Hosts/index-katello.html#Customizing_the_Registration_Templates_managing-hosts

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 15, 2025
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Avital, LGTM.

@apinnick apinnick changed the title Removing custom templates snippet Remove custom templates snippet Sep 15, 2025
@apinnick apinnick merged commit 37ee866 into theforeman:master Sep 16, 2025
10 of 12 checks passed
@apinnick apinnick deleted the custom-templates-note-snippet branch September 16, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants