Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel version template output parsing fix #56

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Kernel version template output parsing fix #56

merged 2 commits into from
Oct 10, 2023

Conversation

nadjaheitmann
Copy link
Collaborator

Found multiple bugs, unfortunately after the new release.

  1. The template description was duplicate for two templates, this is why the view patch job would not work (it would enter the tasks extension although it should not).
  2. I had to adjust the parsing with the newlines as it would not work on newer Foreman version - I hope it is now working on all systems. Also I realized that kcare and kernel turned out mixed up after last update of the Kernel version template. Would be good to implement a unit test for that - this is really avoidable.

@nadjaheitmann nadjaheitmann changed the title Issue/foreman kernel care Kernel version template not working Oct 6, 2023
@nadjaheitmann nadjaheitmann changed the title Kernel version template not working Kernel version template output parsing fix Oct 6, 2023
@sbernhard
Copy link
Collaborator

LGTM

@maccelf maccelf merged commit 2429eae into theforeman:master Oct 10, 2023
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernhard sbernhard sbernhard approved these changes

@maccelf maccelf maccelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadjaheitmann @sbernhard @maccelf