Include socket services while stopping services during restart

[Gauravtalreja1]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2067120

Results:

# foreman-maintain service restart --only foreman
Running Restart Services
================================================================================
Check if command is run as root user:                                 [OK]
--------------------------------------------------------------------------------
Restart applicable services:

Stopping the following service(s):
foreman, foreman.socket
\ All services stopped

Starting the following service(s):
foreman
/ All services started                                                [OK]
--------------------------------------------------------------------------------

[ehelms]

@evgeni @ekohl do y'all remember where we landed on this?

[ekohl]

I really wonder why we don't call the restart action. I mean, systemctl is perfectly capable of calling stop and start itself if there's no restart defined. That also gets rid of the warning.

[ehelms]

Mind filing an issue for that? we could ask to include that change here but it sorta muddies the waters.

[Gauravtalreja1]

@ehelms Could you please create a redmine issue for this? Thanks

[Gauravtalreja1]

@ehelms @ekohl Could you please take a look at this? It has been pending for a few months now

[evgeni]

Two things:

• In the meantime https://bugzilla.redhat.com/show_bug.cgi?id=2067120 was closed as a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=2154917, which I'd say is wrong (fixing the later fixes the former, but it's not a dupe per se)
• Doesn't this change mean that foreman-maintain service restart will stop sockets, but not start them again?
  • Edit: seems to work fine based on the packit build below

/packit build

[packit-as-a-service]

No config file for packit (e.g. .packit.yaml) found in theforeman/foreman_maintain on commit 42adca6

For more info, please check out the documentation or contact the Packit team.

[Gauravtalreja1]

@ehelms Thanks for addressing the comment above in #733, I've updated this PR to use restart and include sockets for restart action to avoid this socket warnings, please can you re-visit this PR, if you think this PR is still valid, else we can close this. Thank you!

[ehelms]

From my quick test, when we switched to using systemd restart, this was inherently fixed, here is output without this fix:

# foreman-maintain service restart --only foreman
Running Restart Services
================================================================================
Check if command is run as root user:                                 [OK]
--------------------------------------------------------------------------------
Restart applicable services: 

Restarting the following service(s):
foreman
/ All services restarted                                              [OK]      
--------------------------------------------------------------------------------

[Gauravtalreja1]

@ehelms Yes, I've also tried, this warning disappears when using restart, but sockets aren't included in it, so do you think if it makes sense to include sockets while restart? if not, then we're good to close this PR I think, Thanks!

[ehelms]

I do not think we need to include sockets as systemd handles this for us.