Add final upgrade step to check if reboot needed

[ehelms]

This is intended to automate into the procedure and be able to drop from our documentation running the command explicitly. I have included example outputs below. My only concern is whether this is too "hidden" of output for the user and if instead we need more of special post upgrade output (similar to the installer) that clearly articulates any upgrade considerations.

Output if reboot needed:

Running Checks after upgrading to Satellite 6.15.z
================================================================================
Clean old Kernel and initramfs files from tftp-boot:                  [OK]
--------------------------------------------------------------------------------
Check number of fact names in database:                               [OK]
--------------------------------------------------------------------------------
Check whether all services are running:                               [OK]
--------------------------------------------------------------------------------
Check whether all services are running using the ping call:           [OK]
--------------------------------------------------------------------------------
Check for paused tasks:                                               [OK]
--------------------------------------------------------------------------------
Check whether system is self-registered or not:                       [OK]
--------------------------------------------------------------------------------
Check if only installed assets are present on the system: 
| Checking for presence of non-original assets...                     [OK]      
--------------------------------------------------------------------------------
Check if system needs reboot: 
Updating Subscription Management repositories.
Core libraries or services have been updated since boot-up:
  * dbus
  * dbus-daemon
  * kernel
  * linux-firmware
  * systemd

Reboot is required to fully utilize these updates.
More information: https://access.redhat.com/solutions/27943           [OK]
--------------------------------------------------------------------------------


--------------------------------------------------------------------------------
Upgrade finished.

Example if no reboot:

Running Checks after upgrading to Satellite 6.15.z
================================================================================
Clean old Kernel and initramfs files from tftp-boot:                  [OK]
--------------------------------------------------------------------------------
Check number of fact names in database:                               [OK]
--------------------------------------------------------------------------------
Check whether all services are running:                               [OK]
--------------------------------------------------------------------------------
Check whether all services are running using the ping call:           [OK]
--------------------------------------------------------------------------------
Check for paused tasks:                                               [OK]
--------------------------------------------------------------------------------
Check whether system is self-registered or not:                       [OK]
--------------------------------------------------------------------------------
Check if only installed assets are present on the system: 
| Checking for presence of non-original assets...                     [OK]      
--------------------------------------------------------------------------------
Check if system needs reboot: 
No core libraries or services have been updated since boot-up.
Reboot should not be necessary.
More information: https://access.redhat.com/solutions/27943           [OK]
--------------------------------------------------------------------------------


--------------------------------------------------------------------------------
Upgrade finished.

[evgeni]

why isn't the step just tagged with post_upgrade?

[ehelms]

I want it to be the final step so the user sees it.

[ehelms]

Hence my question above:

My only concern is whether this is too "hidden" of output for the user and if instead we need more of special post upgrade output (similar to the installer) that clearly articulates any upgrade considerations.

[ehelms]

Here is the updated output:

Check if system needs reboot:                                         [WARNING]
Updating Subscription Management repositories.
Core libraries or services have been updated since boot-up:
  * dbus
  * dbus-daemon
  * glibc
  * kernel
  * linux-firmware
  * systemd

Reboot is required to fully utilize these updates.
More information: https://access.redhat.com/solutions/27943
--------------------------------------------------------------------------------
Scenario [Checks after upgrading to Satellite 6.15.z] failed.

The following steps ended up in warning state:

  [packages-check-for-reboot]

The steps in warning state itself might not mean there is an error,
but it should be reviewed to ensure the behavior is expected

I am not the biggest fan of that "what does warning mean" output, but we can live with it.

[ehelms]

I could look into introducing a different output for this to add before or after this change? Maybe that's a bigger follow up to tackle as part of some overall changes.

[ehelms]

I learned that this results in an exit code 78 as that is what we issue for a warning state, I wonder if that will result in this being interpreted as failed by users / scripts?

[evgeni]

If they take notice, this is what we wanted, no? :)

(Didn't you yourself pondered about an exit code at some point?)