deprecate snapshot backups #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Oct 6, 2023
|
What about adding a DEPRECATED to the description -- https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/cli/backup_command.rb#L158? |
|
Mhh. This is not really visible: [root@centos8-stream-foreman-nightly ~]# foreman-maintain backup snapshot /lol
WARNING: Snapshot backups are deprecated and will be removed in a future version.
Starting backup: 2023-10-09 08:10:25 +0000
Running preparation steps required to run the next scenarios
================================================================================
Make sure Foreman DB is up:
/ Checking connection to the Foreman DB [OK]
-------------------------------------------------------------------------------- |
evgeni
force-pushed
the
warn-drop-snapshot
branch
3 times, most recently
from
2250b41
to
ff8d4f2
Compare
|
now: # foreman-maintain backup snapshot /lol
Starting backup: 2023-10-09 08:46:00 +0000
Running preparation steps required to run the next scenarios
================================================================================
Make sure Foreman DB is up:
/ Checking connection to the Foreman DB [OK]
--------------------------------------------------------------------------------
Running Backup
================================================================================
Snapshot backups are deprecated: [WARNING]
Snapshot backups are deprecated and will be removed in a future version.
--------------------------------------------------------------------------------
Confirm turning off services is allowed:
WARNING: This script will stop your services. |
evgeni
force-pushed
the
warn-drop-snapshot
branch
from
ff8d4f2
to
b5420d0
Compare
ehelms
reviewed
Oct 9, 2023
| @@ -21,6 +21,7 @@ class Backup < ForemanMaintain::Scenario | |||
|
|
|||
| def compose | |||
| check_valid_startegy | |||
There was a problem hiding this comment.
heh -- just noticed this fun typo startegy
ehelms
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.