Fixes #36877 - Add a pre-upgrade check for katello-agent #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
force-pushed
the
check_katello_agent
branch
from
82c1e89
to
739bca8
Compare
wbclark
force-pushed
the
check_katello_agent
branch
4 times, most recently
from
889efcf
to
b7fbd46
Compare
evgeni
reviewed
Oct 23, 2023
evgeni
reviewed
Oct 23, 2023
evgeni
reviewed
Oct 23, 2023
evgeni
reviewed
Oct 23, 2023
evgeni
reviewed
Oct 23, 2023
wbclark
force-pushed
the
check_katello_agent
branch
from
b7fbd46
to
da2d1d9
Compare
wbclark
force-pushed
the
check_katello_agent
branch
from
da2d1d9
to
14e4609
Compare
wbclark
changed the title
jeremylenz
reviewed
Oct 30, 2023
Comment on lines
+30
to
+32
| " before proceeding with the upgrade. Alternatively, you may skip this check and proceed by"\ | ||
| " running #{maintain_command} again with the `--whitelist` option, which will automatically"\ | ||
| " uninstall katello-agent." |
There was a problem hiding this comment.
As someone new to foreman-maintain, I'm still not sure what command it's telling me to run here. I assume it's not just foreman-maintain --whitelist? Can it give me the exact command I would run?
There was a problem hiding this comment.
I need to figure out how the name to pass to --whitelist is constructed from the label :check_katello_agent_enabled
There was a problem hiding this comment.
OK, so it would be --whitelist="check-katello-agent-enabled" but it turns out the exact language shouldn't be necessary here.
The reason why is that if ANY checks fail, there is general language explaining how to whitelist the failed step.
chris1984
approved these changes
Nov 1, 2023
|
@evgeni it looks like we need a green ACK, do you have a moment to look? |
ehelms
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.