Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to next version of upgrade scenarios, bump to 1.5.0 #792

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Update to next version of upgrade scenarios, bump to 1.5.0 #792

merged 3 commits into from
Dec 15, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 14, 2023

No description provided.

@ehelms ehelms changed the title Next upgrades Update to next version of upgrade scenarios, bump to 1.5.0 Dec 14, 2023
Griffin-Sullivan
Griffin-Sullivan approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Noob question: Is there no way to set this as a constant so you only have to update in one place? Could also be done when branching.

@ehelms
Copy link
Member Author

ehelms commented Dec 15, 2023

Looks good to me! Noob question: Is there no way to set this as a constant so you only have to update in one place? Could also be done when branching.

Not a noob question -- see #671

@ehelms ehelms merged commit fa2e3cb into theforeman:master Dec 15, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @Griffin-Sullivan