Drop rotate-script from executables-section in gemspec #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Sep 24, 2024
| @@ -18,8 +18,7 @@ the Foreman/Satellite up and running." | |||
| s.files += `git ls-files extras`.split("\n") | |||
| s.extra_rdoc_files = ['LICENSE', 'README.md'] | |||
| s.require_paths = ['lib'] | |||
| s.executables = ['foreman-maintain', | |||
| 'foreman-maintain-complete', 'foreman-maintain-rotate-tar'] | |||
There was a problem hiding this comment.
Can we just drop the whole script at this point? foreman-maintain-rotate-tar that is
There was a problem hiding this comment.
Removing it from s.executables ensures that the gem-installer does not create a ruby-wrapper script in /usr/bin/foreman-maintain-rotate-tar.
I am not fully sure, why tar needs to use the shell-script when changing volume.
Also it is only set, if the tar-command does not use --gzip.
The history says we need it for the extract to work smoothly: 2beadc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #929
ToDo: