Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satellite maintain metadata #936

Merged
merged 3 commits into from
Oct 10, 2024
Merged

satellite maintain metadata #936

merged 3 commits into from
Oct 10, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 10, 2024 •
edited
Loading

  • add test for Satellite Upgrade scenario confinement
  • assert target_version
  • move the logic which versions are supported into the downstream concern

@evgeni evgeni force-pushed the satellite-maintain-metadata branch from 0426453 to 0068f29 Compare October 10, 2024 09:12
@evgeni evgeni force-pushed the satellite-maintain-metadata branch 2 times, most recently from 3f780e1 to 057d5b6 Compare October 10, 2024 13:11
@evgeni evgeni marked this pull request as ready for review October 10, 2024 13:27
@evgeni
Copy link
Member Author

evgeni commented Oct 10, 2024

@ehelms updated! (and offended the 👮‍♂️)

ehelms
ehelms approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

@evgeni evgeni force-pushed the satellite-maintain-metadata branch from 15fbc58 to f935d09 Compare October 10, 2024 17:41
@evgeni evgeni force-pushed the satellite-maintain-metadata branch from f935d09 to 91be6bb Compare October 10, 2024 17:43
@evgeni evgeni merged commit aaefe7c into master Oct 10, 2024
8 checks passed
@evgeni evgeni deleted the satellite-maintain-metadata branch October 10, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @ehelms