Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for Foreman GA before announcing Katello #283

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Wait for Foreman GA before announcing Katello #283

merged 1 commit into from
Oct 12, 2023

Conversation

ianballou
Copy link
Contributor

No description provided.

ekohl
ekohl reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this before we run the release pipeline so we also test it against GA instead of the RC. Perhaps even before we start packaging so the RPMs are built using the GA. This can be a difference if there are changes around webpack.

@ianballou ianballou force-pushed the reminder-to-wait-for-foreman-before-releasing-katello branch 2 times, most recently from 474857f to 296bc4e Compare October 12, 2023 16:22
@ianballou
Copy link
Contributor Author

@ekohl I changed the PR to have two waiting points on the Foreman GA.

@ianballou ianballou requested a review from ekohl October 12, 2023 16:22
ekohl
ekohl approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 1f91367 into theforeman:master Oct 12, 2023
3 checks passed
@ianballou ianballou deleted the reminder-to-wait-for-foreman-before-releasing-katello branch October 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

@ekohl ekohl ekohl approved these changes

@Griffin-Sullivan Griffin-Sullivan Awaiting requested review from Griffin-Sullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianballou @ekohl @chris1984