Update README to include signing key config #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Feb 21, 2024
README.md
Outdated
| @@ -114,6 +114,12 @@ For running jobs in Jenkins, make sure you have [access](https://theforeman.gith | |||
| gopass edit theforeman/jenkins-token --create | |||
| ``` | |||
|
|
|||
| For pushing tags in theforeman repositories, you will need to sign your commits. To do so, add your gpg key id as your signing key for git by running: | |||
There was a problem hiding this comment.
I'd move this under the general Setup section, not Gopass. It's also not pushing tags to the repos, but rather creating signed tags. Pushing is the step beyond that. Perhaps something like:
Suggested change
| For pushing tags in theforeman repositories, you will need to sign your commits. To do so, add your gpg key id as your signing key for git by running: | |
| Foreman requires GPG signed git tags. Configure git with your personal gpg key id as your signing key: |
Griffin-Sullivan
force-pushed
the
master
branch
from
447caf8
to
29076f1
Compare
ekohl
approved these changes
Apr 4, 2024
README.md
Outdated
| Foreman requires GPG signed git tags. Configure git with your personal gpg key id as your signing key: | ||
|
|
||
| ``` | ||
| git config --global user.signingKey <your-key-id> |
There was a problem hiding this comment.
We can align it with the same for gopass init below. I'd assume most people use the same GPG key for both.
Suggested change
| git config --global user.signingKey <your-key-id> | |
| git config --global user.signingKey <YOUR-PUB-KEY-HASH> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.