Skip to content

Conversation

@cowboyd
Copy link
Member

@cowboyd cowboyd commented Sep 30, 2025

Motivation

Simulation servers should be addressable as hosts other than "localhost". We ran into a case where we we were binding simulators as a service in docker and a simulator we would normally access as http://localhost:5000 was addressable as http://simulators:5000.

Approach

Remove the explicit binding to "localhost"

@cowboyd cowboyd requested a review from jbolda September 30, 2025 19:32
@frontsidejack
Copy link
Member

frontsidejack commented Sep 30, 2025

Package Changes Through 57ba738

There are 1 changes which include @simulacrum/foundation-simulator with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@simulacrum/foundation-simulator 0.5.1 0.6.0
@simulacrum/auth0-simulator 0.11.1 0.11.2
@simulacrum/github-api-simulator 0.6.1 0.6.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/auth0-simulator@335
npm i https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/foundation-simulator@335
npm i https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/github-api-simulator@335

commit: 57ba738

Copy link
Contributor

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our discussion, I added a commit which adjusted the intent slightly to allow one to pass all the args including the host for those special cases that require it (see auth simulation).

@jbolda jbolda merged commit 7dc3615 into main Oct 9, 2025
5 checks passed
@jbolda jbolda deleted the default-bind-host branch October 9, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants