Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreDrawPlayer and allow returning True from more render hooks #1985

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Add PreDrawPlayer and allow returning True from more render hooks #1985

merged 3 commits into from
Jan 19, 2025

Conversation

adamnejm
Copy link
Collaborator

  • Adds PrePlayerDraw as PreDrawPlayer
  • Allow returning true from PreDrawOpaqueRenderables
  • Allow returning true from PreDrawTranslucentRenderables
  • New helper function that cleanups render, but allows user to return true.

No special permissions, besides the HUD check. I don't think they're needed.

Fixes: #1972

thegrb93
thegrb93 requested changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@thegrb93 thegrb93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update the docs of the modified hooks with the new return

@adamnejm
Copy link
Collaborator Author

adamnejm commented Jan 19, 2025 •
edited
Loading

should update the docs of the modified hooks with the new return

Huh? The doc @returns have been added. Do they not show up for you?

@thegrb93
Copy link
Owner

Must've missed em. I'm on mobile

@thegrb93 thegrb93 merged commit 20a53d0 into thegrb93:master Jan 19, 2025
1 check passed
github-actions bot added a commit that referenced this pull request Jan 19, 2025
@github-actions
Add PreDrawPlayer and allow returning True from more render hooks (#1985
da1e96f 
)

* Add PrePlayerDraw as PreDrawPlayer

* Allow returning True from PreDraw[Translucent|Opaque]Renderables

* Add cleanup render func that allows returning true 20a53d0
github-actions bot added a commit to Superlamaface/StarfallEx that referenced this pull request Jan 20, 2025
@github-actions
Add PreDrawPlayer and allow returning True from more render hooks (th…
7abd637 
…egrb93#1985)

* Add PrePlayerDraw as PreDrawPlayer

* Allow returning True from PreDraw[Translucent|Opaque]Renderables

* Add cleanup render func that allows returning true 20a53d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PrePlayerDraw hook
2 participants
@adamnejm @thegrb93