Skip to content

Don't look up domains twice when skipping cache #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't look up domains twice when skipping cache #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions apps/greencheck/viewsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,12 @@ def retrieve(self, request, *args, **kwargs):

if not via_carbon_txt:
self.clear_from_caches(domain)

if http_response := self.build_response_from_full_network_lookup(domain):
else:
# Try the database green domain cache table first:
if http_response := self.build_response_from_database_lookup(domain):
return http_response

# Try the database green domain cache table first:
if http_response := self.build_response_from_database_lookup(domain):
return http_response

# not in cache table cache, try full lookup using network
# not in cache table cache (or skipped), try full lookup using network
if http_response := self.build_response_from_full_network_lookup(domain):
return http_response

Expand Down