Fix docker setup #635
Open
Fix docker setup #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….toml and run uv sync to prevent any change in the tree from causing this step to run again
…use dotenv to load it
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173, #632
One thing this doesn't do yet is migrate, unlike the gitpod script. The reason for this is that we'd need the
dbcontainer to be running already at that point.Given that the docker container never did that, I decided to consider that out of scope.
I also made an optimization: installing dependencies after copying only the
pyproject.toml, then copying the rest of the tree. This means that the installation step gets cached until thepyproject.tomlis changed. This should significantly increase build speeds in most cases.