Bug/236: Include all gridIntensity values in adjustments when only some are overridden #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APJohns
commented
Nov 7, 2024
| `"${dataCenter.country}" is not a valid country. Please use a valid 3 digit ISO 3166 country code. \nSee https://developers.thegreenwebfoundation.org/co2js/data/ for more information. \nFalling back to global average grid intensity.` | ||
| ); | ||
| adjustments.gridIntensity["dataCenter"] = { | ||
| value: SWDM3_GLOBAL_GRID_INTENSITY, |
There was a problem hiding this comment.
Was this meant to remain as SWDM3_GLOBAL_GRID_INTENSITY? By moving this into the function it will use globalGridIntensity like the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triage
Type of change
Please select any of the below items that are appropriate.
This pull request:
Related issue/s
Please list below any issues this pull request is related to.
Docs changes required
Do any changes made in this pull request require parts of the CO2.js documentation to be updated?
If you answered "Yes", please create an corresponding issue in our Developer Documentation repository.
Describe the changes made in this pull request
When only defining some segment intensities on perVisitTrace, the variables.gridIntensity only has the explicitly set segments. This PR adds the default values.
I also moved the logic into a function to reduce repeated code and align all the segments.
Let me know if I've missed anything or if there is a better approach. Love this project, and I'm excited to contribute where I can!