Update supported versions of nodejs in tests #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triage
Type of change
Please select any of the below items that are appropriate.
This pull request:
Related issue/s
Please list below any issues this pull request is related to.
Docs changes required
Do any changes made in this pull request require parts of the CO2.js documentation to be updated?
If you answered "Yes", please create an corresponding issue in our Developer Documentation repository.
Describe the changes made in this pull request
This pull request includes updates to the GitHub Actions workflow configuration for running unit tests. The changes primarily focus on updating the supported Node.js versions to ones that are inside Nodejs own support window, and updates the actions used in the workflow to use newer versions.
Previously we were running NodeJs on unsupported versions of node, and this was causing failing tests in PRs that shouldn't really have them. See #241 as an example of a PR with failing tests related to the use of Node 14.
Updates to GitHub Actions workflow:
.github/workflows/unittests.yml
: Removed support for theca-v0.10.0
branch from bothpush
andpull_request
events..github/workflows/unittests.yml
: Updated the supported Node.js versions in the matrix strategy to18.x
,20.x
, and22.x
..github/workflows/unittests.yml
: Updatedactions/checkout
to versionv4
andactions/setup-node
to versionv4
.