Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions of nodejs in tests #242

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mrchrisadams
Copy link
Member

@mrchrisadams mrchrisadams commented Nov 15, 2024

Triage

Type of change

Please select any of the below items that are appropriate.

This pull request:

  • Adds a new carbon estimation model to CO2.js
  • Adds new functionality to an existing model
  • Fixes a bug with an existing model implementation
  • Add other new functionality to CO2.js
  • Add new data to CO2.js
  • Improves developer experience for contributors
  • Adds contributors to CO2.js
  • Does something not specified above

Related issue/s

Please list below any issues this pull request is related to.

Docs changes required

Do any changes made in this pull request require parts of the CO2.js documentation to be updated?

  • Yes
  • No
  • I don't know

If you answered "Yes", please create an corresponding issue in our Developer Documentation repository.

Describe the changes made in this pull request

This pull request includes updates to the GitHub Actions workflow configuration for running unit tests. The changes primarily focus on updating the supported Node.js versions to ones that are inside Nodejs own support window, and updates the actions used in the workflow to use newer versions.

Previously we were running NodeJs on unsupported versions of node, and this was causing failing tests in PRs that shouldn't really have them. See #241 as an example of a PR with failing tests related to the use of Node 14.

Updates to GitHub Actions workflow:

@mrchrisadams mrchrisadams merged commit d4731ba into main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant