This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
[example app] updated yarn.lock so latest Theia used #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example application that comes with this repo was still using an earlier Theia version, because of yarn.lock. I have manually removed the @Theia entries and re-ran yarn: now the latest version of Theia packages are picked-up. As well, with this change, we are now avoiding the example application using a moderate severity security vulnerability, present in dependency "fstream < 1.0.12". Signed-off-by: Marc Dumais <[email protected]>
|
Hi @AlexTugarev : no rush for this review - I'm happy if you focus on TheiaDevCon at the moment :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example application that comes with this repo was still
using an earlier Theia version, because of yarn.lock. I
have manually removed the @Theia entries and re-ran yarn:
now the latest version of Theia packages are picked-up.
As well, with this change, we are now avoiding the example
application using a moderate severity security vulnerability,
present in dependency "fstream < 1.0.12".
Signed-off-by: Marc Dumais [email protected]