🔪 reps-per-round #83
Merged
🔪 reps-per-round #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
theianjones
commented
Nov 7, 2023
theianjones
commented
theianjones
commented
Nov 7, 2023
Comment on lines
+23
to
+24
| [{:keys [rounds] :as params}] | ||
| (+ (/ (float (reps->score params)) REPS_MULTIPLIER) (n/parse-int rounds))) |
There was a problem hiding this comment.
instead of referencing the reps per round to normalize score, we divide by 1000 and add that remainder to the rounds integer.
Comment on lines
+60
to
+65
| (is (= [{:reps "116" :index 0 :notes "" :id nil} | ||
| {:reps "102" :index 1 :notes "fell off my pace" :id nil} | ||
| {:reps "96" :index 2 :notes "couldnt think anymore" :id nil}] | ||
| (sut/->scores params-with-reps)))) | ||
| (testing "defaults rounds to score to 1" | ||
| (is (= [{:reps "116" :index 0 :notes ""}] | ||
| (is (= [{:reps "116" :index 0 :notes "" :id nil}] |
There was a problem hiding this comment.
I dont think our tests run in ci... these were failing lol
Comment on lines
+10
to
+19
| [reps-per-round score] | ||
| (if (int? score) | ||
| (if (> 0 score) | ||
| "0+0" | ||
| (str (quot score reps-per-round) | ||
| "+" | ||
| (rem score reps-per-round))) | ||
| (let [rounds (.intValue score) | ||
| reps (.intValue (* REPS_MULTIPLIER (- (bigdec score) rounds)))] | ||
| (str rounds "+" reps)))) |
There was a problem hiding this comment.
this will handle old results that require reps-per-round and new results that we record.
We can merge this and things shouldnt break, migrate the old data to be a float, then delete the if block here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.