Repository navigation
feat(catalog): add tissue/disease facet-hierarchy columns to schema - #69
Merged
Merged
Conversation
The hub cut emits tissue_system/_id, tissue_organ/_id, disease_class/_id and disease_group/_id (computed from the pinned UBERON/MONDO node graphs + anchor tables). Declare them as nullable string columns so the client carries them.
Documentation build overview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 22 22
Lines 2291 2291
=======================================
Hits 2169 2169
Misses 122 122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the 8 facet-hierarchy columns the hub cut now emits to
CATALOG_COLUMNSso the client carries them:tissue_system,tissue_system_id,tissue_organ,tissue_organ_iddisease_class,disease_class_id,disease_group,disease_group_idAll nullable
string, not required (old parquets without them still validate; the hub emits them as part of the facet-hierarchy work merged in the hub main). Names/dtypes matched against the hubpublish/catalog.pyfacet computation.Scope note: this only declares the columns. Whether tissue_system/organ and disease_class/group become filterable
FACETS(for the site tree) is a separate client/web decision, left out here.