Repository navigation
feat(schema): observation_unit, unit_size_um and observation_unit_source catalog columns - #71
Merged
Merged
Conversation
…rce catalog columns What one table row is in spatialdata-io's vocabulary (spot_or_bin / cell / subcellular_bin / region), the spot diameter or bin side in um, and whether the hub read them from the table's uns['spatialdata_io'] or from its technology map. Optional, nullable. obs_unit (the card noun) stays.
Documentation build overview
4 files changed± index.html± intro/assays.html± intro/db-stack.html± reference/catalog-columns.html |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 22 22
Lines 2313 2313
=======================================
Hits 2191 2191
Misses 122 122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three optional catalog columns:
observation_unit: what one table row is, in spatialdata-io's vocabulary (spot_or_bin,cell,subcellular_binorregion).unit_size_um: the spot diameter or bin side in µm. It is null for cells and when unknown.observation_unit_source:tablewhen the hub read the unit from the table'suns["spatialdata_io"], ortechnology_mapwhen it fell back to its technology map (zarrs written before the reader recorded the unit).obs_unit, the noun the website shows, is unchanged.The hub fills the three columns in a companion PR on the hub (T117). Tests:
test_catalog_schemachecks the new columns, and the rest of the suite passes (447 passed).