Repository navigation
feat(query): filter on the tissue and disease roll-up columns - #73
Merged
Merged
Conversation
query() rejected tissue_system, tissue_organ, disease_class and disease_group, although the hub cut publishes them and the MCP connector's snippets filter on them, e.g. Catalog(version="2026-11-08").query(tissue_organ="brain", validation=None). They are now facets. Each row carries its anchor, so equality on an anchor includes every tissue or disease under it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 22 22
Lines 2326 2326
=======================================
Hits 2206 2206
Misses 120 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP connector (spatialdata-db-web #99) gives snippets such as
Catalog(version="2026-11-08").query(tissue_organ="brain", validation=None).query()rejected them, becausetissue_system,tissue_organ,disease_classanddisease_groupwere catalog columns but not facets.Changes:
FACETS. The hub cut writes each row's anchor, so equality on an anchor includes every tissue or disease under it.Checks:
validation=None. For example,tissue_organ="brain"gives 4,022 datasets andorganism="human", tissue_organ="brain", technology="Xenium"gives 164.Users who install from the v0.1.3 tag get this only after a new tag.