Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve markup, reduce height of navbar, use GitHub logo, add a link to themes #95

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Improve markup, reduce height of navbar, use GitHub logo, add a link to themes #95

merged 3 commits into from
Oct 26, 2018

Conversation

astorije
Copy link
Member

@astorije astorije commented Oct 25, 2018 •
edited
Loading

Extracted from #84.
Fixes #8.

Before After
screen shot 2018-10-25 at 01 39 59 screen shot 2018-10-25 at 02 00 13

Notes

  • Font Awesome is not at latest version. I have updated it in [WIP] New docs #84 but in a commit that changes too many things that are not in master yet so I'll do that later.
  • The navigation is not optimized for mobile yet (though not broken either), same as previous item.

Both of those things will be addressed in further PRs as I keep thinning out #84.

xPaw
xPaw reviewed Oct 25, 2018
View reviewed changes
_layouts/default.html Outdated
</a>

<ul class="nav-links">
<li><a href="/docs">Docs</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the full Documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, done.

@astorije astorije requested a review from xPaw October 25, 2018 23:59
This was referenced Oct 26, 2018
Merged
Merged
@xPaw xPaw merged commit 52fbc6a into master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xPaw xPaw xPaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astorije @xPaw