Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set "unsafe-perm" as true to fix eb deploy issue #453

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Set "unsafe-perm" as true to fix eb deploy issue #453

merged 1 commit into from
Oct 9, 2019

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Oct 9, 2019

@robertu7 robertu7 added the ready label Oct 9, 2019
devformatters
devformatters reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@devformatters devformatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go. 👽

@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #453 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #453   +/-   ##
=======================================
  Coverage     45.6%   45.6%           
=======================================
  Files          268     268           
  Lines         4749    4749           
  Branches       852     852           
=======================================
  Hits          2166    2166           
  Misses        2577    2577           
  Partials         6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5562d2...5f880e2. Read the comment docs.

@robertu7 robertu7 merged commit 32f1f2d into develop Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/eb-deploy-perm branch October 9, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devformatters devformatters devformatters approved these changes

@guoliu guoliu Awaiting requested review from guoliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertu7 @devformatters