Drops --legacy-peer-deps from #4829

[robertu7]

PR from #4829 by @lizhineng

[robertu7]

@lizhineng you can try to preview here: https://matters-web-git-fix-peer-dependency-matters.vercel.app/

I found there are some issue on local cache of article page. You can reproduce:

1. Open the homepage;
2. Click on any article;
3. Click on any link in the article page;
4. Go back to article page: expected not to show the loading state;

[lizhineng]

The article refresh you’re seeing is actually expected. The useEffect hook runs whenever the component gets mounted back to the page.

In Apollo Client v2, the loading state didn’t visibly update, but the HTTP requests were still happening behind the scenes. I’ve recorded a video showing how this works in production for reference.

matters-article-refresh.mov

Here's a PR that applies a quick fix for the "issue." I don’t have a complete understanding of the business logic, so feel free to close this if it doesn't work as expected or causes any problems.

[robertu7]

Thanks for your debugging, i think this bug it's brought a fix from #3904, however, it's not useful anymore.

I don’t have a complete understanding of the business logic, so feel free to close this if it doesn't work as expected or causes any problems.

We still need the useEffect hook to fetch the "private data" to ensure that the data and rendering are correct for the current user and article state. We will close your PR and push the commit later.

[robertu7]

[lizhineng]

Is this error caused by these PR changes? How do you reproduce it and maybe I can look it up.