General Improvements: C extension, Py2 Py3 compatibility, Performance #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrote python code to match C code more closely -- which doubled the performance (on my machine) - Python 2 and Python 3 compatible (except for the doctests, sorry).
|
Thanks for the PR! I'm a bit swamped with my day job and goals; I'll try to take a look this weekend. Sorry about the delay in communication! |
|
No problem at all -- I hope the PR is somewhat acceptable to you. :) |
... because this is easier than fixing the extension on Windows.
Only build C-extension if not on Windows
This enables us to do "pip install git+<repo-URI>".
Move setup.py to root level.
Remove the / at the end of the paths in setup.py
|
Hi, any news on this PR? :) |
|
Any chance this PR will get merged? |
Fix segfault on py37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I recently experimented with this library and wrote a C extension for it.
It is my very first C extension and I had many looks at the great python-blosc C extension (https://github.com/Blosc/python-blosc/blob/master/blosc/blosc_extension.c).
Perhaps you might want to review, rewrite, or even include this pull request into your repo.
Please feel free to cherry pick. :-)
Best regards,
Tim