Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology #47

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Topology #47

wants to merge 9 commits into from

Commits on Aug 4, 2021

  1. Fix calculating neighbors in critcal.py 

    Moving a vector to a new-direction requires the formula:
"vector + direction". The old way wasn't calculating
the direction but rather just adding two vectors
    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    137abc3 View commit details
    Browse the repository at this point in the history

  2. Add nan check to critical point finder 

    The New-ton raphson algorithm for finding the roots/critical points
sometimes returns nan. I added a check here to the if statement.
    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    d6dbf0f View commit details
    Browse the repository at this point in the history

  3. Change the order of if-statements in critical algo 

    First change is to make sure, if there is LinAlg error then
to discontinue.
If the density is zero, then discontinue
if the gradient isn't zero, then discontinue.
    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    4ee8e95 View commit details
    Browse the repository at this point in the history

  4. Add tests to critical point finder

    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    cf933df View commit details
    Browse the repository at this point in the history

  5. Fix comment error in critical.py

    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    40c4481 View commit details
    Browse the repository at this point in the history

  6. Clean up if statements in critical.py

    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    448fcae View commit details
    Browse the repository at this point in the history

  7. Add header to test critical

    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    ca3b08a View commit details
    Browse the repository at this point in the history

  8. Revert "Fix calculating neighbors in critcal.py" 

    This reverts commit 137abc3.
    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    32aa9d4 View commit details
    Browse the repository at this point in the history

  9. Revert "Change the order of if-statements in critical algo" 

    This reverts commit 4ee8e95.
    @Ali-Tehrani
    Ali-Tehrani committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    64f0405 View commit details
    Browse the repository at this point in the history