Skip to content

Conversation

msricher
Copy link
Contributor

@msricher msricher commented Jun 26, 2024

Add profiling capabilities to GBasis. By running py.test [FILES] --profile or py.test [FILES] --profile-svg, the test that is ran will be profiled and profile information (.prof) and optionally a heat map in .svg format will be generated in prof/.

pip install .[test] will now pull in the required libraries for this to work.

Checklist

  • Write a good description of what the PR does.
  • Add tests for each unit of code added (e.g. function, class)
  • Update documentation
  • Squash commits that can be grouped together
  • Rebase onto master

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related

@PaulWAyers
Copy link
Member

@msricher is this ready to merge? I'm not sure if you got an offline review from @marco-2023 or @FarnazH or @leila-pujal or @gabrielasd ?

@leila-pujal
Copy link
Collaborator

Hi @PaulWAyers, on my side I didn't get to review this. I vaguely remember that maybe the goal was to do a profiling of Gbasis to know where the bottlenecks are without adding this feature into Gbasis, but it's been some time since we worked on this so I could very well be mixing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants