Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 182 additions & 0 deletions docs/doc-freshness-sla.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,182 @@
# 文件鮮度保證機制(Doc Freshness SLA)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這段敘述建議補上可驗證的操作步驟或明確的 acceptance criteria,避免後續落地時解讀分歧。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這段文件描述目前偏概念;為了可落地與可驗證,建議補齊:

  • 名詞/狀態定義(觸發條件、例外清單)
  • failure mode(延遲、重複執行、外部依賴失效)與對應處置
  • 最小可行範例(至少 1–2 個具體案例)。

## 背景
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

若此設計涉及例外/邊界情境(例如:逾時、重入、並行),建議在文件中加上一小節說明預期行為與取捨。


claw-info 中的文件(`docs/`、`usecases/`)具有時效性。例如某功能在 v3.11 新增,可能在 v4.x 已被修改或移除。若文件長期無人維護,agent 讀取後可能產生錯誤行為。

## Frontmatter 標準欄位

每份文件須加入以下欄位:

```yaml
---
last_validated: YYYY-MM-DD
validated_by: <github-username>
freshness: ok # ok | stale | unreviewed
---
```

### 初始狀態

新文件合併時應預設 `freshness: ok`(剛撰寫即為剛驗證),而非 `unreviewed`。

### 最小範本

```yaml
---
last_validated: 2026-03-24
validated_by: thepagent
freshness: ok
---
```

### 反例(錯誤寫法)

```yaml
# ❌ 缺少欄位
---
title: My Doc
---

# ❌ 日期格式錯誤
last_validated: 24/03/2026

# ❌ 新文件用 unreviewed
freshness: unreviewed
```

## Review 週期(依文件類型分級)

| 路徑 | 週期 |
|------|------|
| `usecases/` | 2 週 |
| `docs/` | 4 週 |
| 架構圖、穩定參考文件 | 8 週 |

## 自動化流程(GHA)

### Workflow 設計

```yaml
# .github/workflows/doc-freshness-check.yml
name: Doc Freshness Check
on:
schedule:
- cron: '0 2 * * 1' # 每週一 UTC 02:00
workflow_dispatch:

jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check stale docs and open issues
env:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

腳本中的 為 GNU 特定語法,在 macOS 環境(如部分 agent 運行環境)中將失效。建議導入跨平台偵測邏輯或改用 Python one-liner 以確保執行的一致性。

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正:新增 to_epoch() 函式,自動偵測 GNU / macOS BSD 環境並選擇對應語法。

GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MAX_ISSUES: 50
GRACE_DAYS: 7
run: bash .github/scripts/check_freshness.sh
```

> 現行執行版見 [#349](https://github.com/thepagent/claw-info/pull/349)(MVP workflow,issue-based,不自動改檔)。

### 核心腳本(`.github/scripts/check_freshness.sh`)

```bash
#!/usr/bin/env bash
set -euo pipefail

TODAY=$(date +%s)

# 跨平台 date 解析(GNU / macOS BSD)
to_epoch() {
if date -d "2000-01-01" +%s >/dev/null 2>&1; then
date -d "$1" +%s # GNU coreutils (Linux)
else
date -jf '%Y-%m-%d' "$1" +%s # BSD date (macOS)
fi
}

threshold_for() {
case "$1" in
usecases/*) echo 14 ;;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 解析 YAML frontmatter 存在高度風險。應採用 或專門的 YAML 解析模組,以處理引號、多行字符串等邊界情況,確保解析過程的穩健性。

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正:新增 parse_field() 函式,優先使用 yq;無 yq 時 fallback 至 awk state machine,僅讀取 --- 區塊內容,避免誤判正文。

docs/*) echo 28 ;;
*) echo 56 ;;
esac
}

# 使用 yq 解析 frontmatter(需安裝 yq v4+)
# 若無 yq,fallback 至 awk(僅讀 --- 區塊內容,避免誤判正文)
parse_field() {
local file="$1" field="$2"
if command -v yq >/dev/null 2>&1; then
yq e ".${field}" "$file" 2>/dev/null | grep -v '^null$' || true
else
awk "/^---/{f=!f; next} f && /^${field}:/{print \$2; exit}" "$file" | tr -d '\r'
fi
}

while IFS= read -r -d '' f; do
last=$(parse_field "$f" last_validated)
owner=$(parse_field "$f" validated_by)
[ -z "$last" ] && continue

last_epoch=$(to_epoch "$last") || continue
age=$(( (TODAY - last_epoch) / 86400 ))
threshold=$(threshold_for "$f")

if [ "$age" -gt "$threshold" ]; then
title="[Doc Review] $f 需要驗證"
existing=$(gh issue list --label doc-review --search "$title" --state open --json number --jq length)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One operational edge case here: if validated_by points to a user who no longer has assign permission in this repo, gh issue create --assignee can fail and prevent the review issue from being opened at all. It may be safer to make assignee best-effort, or document the fallback behavior explicitly.

if [ "$existing" -eq 0 ]; then
gh issue create \
--title "$title" \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script currently scans only docs and usecases, but the policy text also mentions stable reference material more generally. If that broader category is intentional, it may help to call out here that the MVP scope is limited to those two directories, otherwise readers may assume the workflow covers every markdown doc in the repo already.

--body "上次驗證:$last(${age} 天前)。

請於 7 天內完成以下步驟並送 PR:
- [ ] 對照 source code 確認內容仍正確
- [ ] 若有過時內容,一併修正
- [ ] 更新 \`last_validated\` 為今日日期
- [ ] 更新 \`freshness: ok\`(驗證完成後)
- [ ] 若 ownership 異動,更新 \`validated_by\`" \
--assignee "$owner" \
--label doc-review
fi
fi
done < <(find docs usecases -type f -name "*.md" -print0 2>/dev/null)
```

### Issue 格式

```
標題:[Doc Review] docs/xxx.md 需要驗證
Body:
- 文件路徑
- 上次驗證:YYYY-MM-DD(N 天前)
- 驗證 checklist(確認內容、修正過時處、更新 last_validated + freshness)
Assignee:validated_by 欄位的 GitHub username
Label:doc-review
```

## 不回應的後果

- 超過 deadline(+7 天)未處理:文件標記為 `freshness: stale`
- Agent 讀取 stale 文件時,自動附加警告:`⚠️ 此文件已超過 review 週期,內容可能過時`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這裡宣稱『Agent 讀取 stale 文件時自動附加警告』屬於產品行為,請補:1) 目前是否已有實作(連到 PR/issue/代碼路徑);2) 若尚未實作,需標記為 future work。否則這段會被讀者誤當成既有能力。

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正:加上 ⚠️ Future work 標註,明確說明 stale 警告機制尚未實作,待後續 PR 追蹤。

> ⚠️ **Future work**:此警告機制尚未實作,待後續 PR 追蹤。
- 其他 agent 或貢獻者可接手更新
- **連續 2 次 review cycle(約 30 天)未回應**:原作者從信任名單中移除,文件開放 `help-wanted` 認領

## Agent 驗證流程

Agent 執行 review 時:

1. 讀取文件內容
2. 用 `gh search code` 查對應 source code
3. 比對是否有 breaking change 或 API 變更
4. 若有差異,自動送 PR 修正
5. 更新 frontmatter `last_validated`

## 相關 Issue

- [#346 提案:文件鮮度保證機制](https://github.com/thepagent/claw-info/issues/346)
- [#349 MVP workflow 實作](https://github.com/thepagent/claw-info/pull/349)
Loading