Use ArrayAccessor in GenericResourceOwner#788
Closed
AndreiIgna wants to merge 5 commits intothephpleague:masterfrom
AndreiIgna:patch-1
Closed
Use ArrayAccessor in GenericResourceOwner#788AndreiIgna wants to merge 5 commits intothephpleague:masterfrom AndreiIgna:patch-1
AndreiIgna wants to merge 5 commits intothephpleague:masterfrom
AndreiIgna:patch-1
Conversation
Allow the `resourceOwnerId` to be specified in more formats, like `user.id`
Author
|
Second commit adds // at the moment
$userData = $resourceOwner->toArray();
$userField = $userData['field'];
$userField2 = $userData['group']['field'];
// with getAttribute() method
$userField = $resourceOwner->getAttribute('field');
$userField2 = $resourceOwner->getAttribute('group.field'); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=============================================
- Coverage 100.00% 99.57% -0.43%
- Complexity 180 181 +1
=============================================
Files 20 20
Lines 464 466 +2
=============================================
Hits 464 464
- Misses 0 2 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
resourceOwnerIdto be specified in more formats, likeuser.id.This would enable the
GenericProviderto be used with more OAuth APIs.Slack, for example, returns the user info in a nested array https://api.slack.com/methods/users.identity#response
By accepting this PR, the Slack OAuth and others can be used with the
GenericProvider.