Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RSpeekenbrink
Copy link

@RSpeekenbrink RSpeekenbrink commented Jan 6, 2020

Remove unused amount parameter in CompletePurchaseRequest. Validation on this parameter means you have to access your order before you can actually access the PaymentId trough a gateway meaning you have to add custom logic for buckaroo payments. IE:

$order = Order::find($request->get('BQ_INVOICENUMBER'));
$response = Omnipay::CompletePurchase(array_merge(
    [ 'amount' => $order->amount ],
    request()->all(),
))->send();

With this fix this is no longer required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant