Fix duplicate slot in exam schedule #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for contributing! Were you able to reproduce the linked issue? I don't think this would solve the issue, it might cause cards to have incorrect slots. |
|
I was able to reproduce the issue and as you said it caused the cards to have incorrect slots but now this works good. Can you review once? Beforebefore.mp4Afterafter.mp4 |
app/src/main/java/tk/therealsuji/vtopchennai/adapters/ExamsItemAdapter.java
Outdated
Show resolved
Hide resolved
|
Awesome! Thanks! |
therealsujitk
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duplicate slots are getting added when the user scrolls in the exam schedule. This has been fixed
Fixes #115