Skip to content

Fix duplicate slot in exam schedule#117

Merged
therealsujitk merged 1 commit intotherealsujitk:masterfrom
ezhil56x:exam-schedule
Apr 6, 2024
Merged

Fix duplicate slot in exam schedule#117
therealsujitk merged 1 commit intotherealsujitk:masterfrom
ezhil56x:exam-schedule

Conversation

@ezhil56x
Copy link
Copy Markdown
Contributor

@ezhil56x ezhil56x commented Mar 31, 2024

Description

Duplicate slots are getting added when the user scrolls in the exam schedule. This has been fixed

Fixes #115

@therealsujitk
Copy link
Copy Markdown
Owner

Hi, thanks for contributing! Were you able to reproduce the linked issue? I don't think this would solve the issue, it might cause cards to have incorrect slots.

@ezhil56x
Copy link
Copy Markdown
Contributor Author

ezhil56x commented Apr 1, 2024

I was able to reproduce the issue and as you said it caused the cards to have incorrect slots but now this works good. Can you review once?

Before
before.mp4
After
after.mp4

Comment thread app/src/main/java/tk/therealsuji/vtopchennai/adapters/ExamsItemAdapter.java Outdated
@therealsujitk
Copy link
Copy Markdown
Owner

Awesome! Thanks!

@therealsujitk therealsujitk merged commit 8b8406d into therealsujitk:master Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slots get added additively on the exam schedule screen on acroll

2 participants